-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Raku lexer #476
Add Raku lexer #476
Conversation
Thanks, but CI failed. |
Thanks, but CI is failing. |
Also can you add a test? See lexers/README.md for details. |
Circleci needs logging in, I find that ridiculous, so I can't see what is failing. When I used the Chroma command line tool there was no error. |
Yes, that is annoying I agree. The failure is linter failures. You'll need golangci-lint 1.26.0 to check this locally.
|
This is unrelated, it says change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I just looked at the actual code. I hadn't realised that you'd manually written this lexer. Impressive work, thank you!
Just one small comment, but otherwise LGTM.
@@ -260,7 +260,7 @@ go get -u github.com/alecthomas/chroma/cmd/chroma | |||
|
|||
- Quite a few lexers, for various reasons (pull-requests welcome): | |||
- Pygments lexers for complex languages often include custom code to | |||
handle certain aspects, such as Perl6's ability to nest code inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence now no longer makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only removed the perl6 part and missed the regular expressions part.
Do you mean the whole "Pygments lexers for complex languages often include custom code to..." part. or just that "regular expressions part"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just mean it now reads "handle certain aspects regular expressions", which doesn't make sense. Maybe just revert this, or did you mean to change it to Raku?
Hehe, yeah it took me about two to three weeks! I started from the lexer generated by |
Awesome, thanks! |
Sorry, I meant to merge this! |
Fixes #306